[core] Apply () function convention #15075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
oliviertassinari
force-pushed
the
function-docs
branch
3 times, most recently
from
82bb0c7
to
64a1475
Compare
oliviertassinari
force-pushed
the
function-docs
branch
from
64a1475
to
b5c1eff
Compare
LukasTy
approved these changes
Oct 24, 2024
LukasTy
approved these changes
Oct 24, 2024
Signed-off-by: Lukas Tyla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick iteration on mui/mui-public#218. I wanted to test this idea more fully before people try to get it deployed at 100% in the codebase.
It seems to work. One case that I didn't add
()is when those are part of props, because developers can't them. cc @samuelsycamore